Skip to content

Conversation

@stevhliu
Copy link
Member

Adds a "warning" and "lightbulb" icon for the Warning/Tip component as shown below. This helps add some more context to the current Tip component. I can also explicitly add a "Warning" and "Tip" label to the component if we like :)

Screenshot 2025-07-18 at 1 23 22 PM

@stevhliu stevhliu requested a review from mishig25 July 18, 2025 20:40
@mishig25 mishig25 requested a review from gary149 August 13, 2025 03:32
@mishig25
Copy link
Contributor

I'm adding victor as the reviewer since he is in charge of UI designs.
For me the icons look great. However, if we decide to have icons, we would need to perform other tasks for the consistency:

  • the green tip design is shared across all the aspects of the hub (docs, blogs, model cards). Therefore, we would need to add the icons for other parts of hf.co as well (blogs, model cards)
  • in hf.co, besides tip, warning, we have note, important, cation. Therefore, we would need icons for note, important, cation as well

See https://huggingface.co/mishig/test-tips for all the current tip designs

image

@stevhliu
Copy link
Member Author

stevhliu commented Oct 8, 2025

Added icons for the rest of the blockquote admonitions. Let me know what you think @gary149 !

Screenshot 2025-10-08 at 4 44 39 PM

@gary149
Copy link
Contributor

gary149 commented Oct 15, 2025

spacing looks a bit too large to me @enzostvs + how does it look with a single sentence going on multiple lines.

@gary149
Copy link
Contributor

gary149 commented Oct 15, 2025

the spacing looks weird to me but we can merge and we'll see in prod (as build is complex @enzostvs )

@enzostvs
Copy link
Member

enzostvs commented Oct 15, 2025

Agreed, the icon isn't aligned with the text as well and too much space on the right, maybe could be 1,5 instead of 2,5 and add a translate-y-px class to the icon

@stevhliu
Copy link
Member Author

Changed the icon to be more aligned and wrapped the text under the first line!

Screenshot 2025-10-16 at 3 14 10 PM

@enzostvs enzostvs self-requested a review October 16, 2025 23:12
Copy link
Member

@enzostvs enzostvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI wise lgtm!
we could still improve it in the future, but stil cool to have the icons!
(IDK if linked to this PR, but while no "content", there is a big blank inside the component)

@mishig25
Copy link
Contributor

awesome, I will do some local testing and merge 🚀

@stevhliu
Copy link
Member Author

thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants